Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect max and min decimals #1916

Closed
viirya opened this issue Jun 20, 2022 · 0 comments · Fixed by #1917
Closed

Incorrect max and min decimals #1916

viirya opened this issue Jun 20, 2022 · 0 comments · Fixed by #1917
Labels
arrow Changes to the arrow crate bug

Comments

@viirya
Copy link
Member

viirya commented Jun 20, 2022 •
edited

Describe the bug

We define MAX_DECIMAL_FOR_EACH_PRECISION and MIN_DECIMAL_FOR_EACH_PRECISION for max/min decimals per precision. But the max/min for precision 38 looks incorrect.

To Reproduce
Steps to reproduce the behavior:

Expected behavior

For example, according to https://impala.apache.org/docs/build/html/topics/impala_decimal.html, the range of DECIMAL type is -10^38 +1 through 10^38 –1, if max precision is 38.

Additional context
Add any other context about the problem here.
@viirya viirya added the bug label Jun 20, 2022
@viirya viirya mentioned this issue Jun 20, 2022
Merged
@alamb alamb added the arrow Changes to the arrow crate label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix max and min decimal for max precision viirya/arrow-rs
2 participants
@viirya @alamb