Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dictionary IPC writer writes incorrect schema #1892

Closed
andygrove opened this issue Jun 16, 2022 · 0 comments · Fixed by #1893
Closed

Dictionary IPC writer writes incorrect schema #1892

andygrove opened this issue Jun 16, 2022 · 0 comments · Fixed by #1893
Labels
arrow Changes to the arrow crate bug

Comments

@andygrove
Copy link
Member

Describe the bug
PR #1890 seems to have exposed a bug where IPC-encoded dictionaries declare a field with an empty name that does not allow null values but then writes null values in that column.

To Reproduce
Remove the hacky workaround that was added in #1890

Expected behavior
encoded schema should be accurate

Additional context
None
@andygrove andygrove added the bug label Jun 16, 2022
@andygrove andygrove mentioned this issue Jun 16, 2022
Merged
@viirya viirya mentioned this issue Jun 17, 2022
Merged
@alamb alamb changed the title Dictionary IPC writer appears to write incorrect schema Dictionary IPC writer writes incorrect schema Jun 23, 2022
@alamb alamb added the arrow Changes to the arrow crate label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct nullable in read_dictionary viirya/arrow-rs
2 participants
@alamb @andygrove