Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Decimal128 API and use it in DecimalArray and DecimalBuilder #1870

Closed
viirya opened this issue Jun 14, 2022 · 0 comments · Fixed by #1871
Closed

Add Decimal128 API and use it in DecimalArray and DecimalBuilder #1870

viirya opened this issue Jun 14, 2022 · 0 comments · Fixed by #1871
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Jun 14, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Part of #131.

Currently we directly use i128 in decimal related APIs, for example DecimalArray and DecimalBuilder APIs. However, in order to support 256-bit decimal, we need more consistent Decimal API. For example, in C++ Arrow, there are Decimal128 and Decimal256 classes.

This proposes to have Decimal128 API and use it in DecimalArray and DecimalBuilder.

Describe the solution you'd like

Add Decimal128 API and use it in DecimalArray and DecimalBuilder.

Describe alternatives you've considered
Keep i128 in DecimalArray and DecimalBuilder. But there will be inconsistency between Decimal256 related APIs and also inconsistency between C++ Arrow and Rust Arrow APIs.

Additional context
Add any other context or screenshots about the feature request here.

@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Jun 14, 2022
@viirya viirya added the api-change Changes to the arrow API label Jun 14, 2022
@alamb alamb added arrow Changes to the arrow crate and removed api-change Changes to the arrow API labels Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants