Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up arrow::array::builder module #1843

Closed
tustvold opened this issue Jun 10, 2022 · 0 comments · Fixed by #1879 or #1928
Closed

Split up arrow::array::builder module #1843

tustvold opened this issue Jun 10, 2022 · 0 comments · Fixed by #1879 or #1928
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The arrow::array::builder module is implemented as one immense builder.rs file, this has a number of drawbacks:

Describe the solution you'd like

I would like to split out the various builders from builder.rs into their own submodules, e.g.

builder/mod.rs
builder/buffer_builder.rs
builder/boolean_builder.rs
...

The top-level builder/mod.rs can then re-export each of these with pub use to avoid introducing breaking changes.

Describe alternatives you've considered

We could not do this

@tustvold tustvold added good first issue Good for newcomers enhancement Any new improvement worthy of a entry in the changelog help wanted labels Jun 10, 2022
DaltonModlin added a commit to DaltonModlin/arrow-rs that referenced this issue Jun 15, 2022
DaltonModlin added a commit to DaltonModlin/arrow-rs that referenced this issue Jun 15, 2022
DaltonModlin added a commit to DaltonModlin/arrow-rs that referenced this issue Jun 15, 2022
DaltonModlin added a commit to DaltonModlin/arrow-rs that referenced this issue Jun 15, 2022
- Removed old builder.rs
- Added missing licensing header to builder submodules
- Updated builder submodule imports and exports
- Updated array mod file builder imports and exports
DaltonModlin added a commit to DaltonModlin/arrow-rs that referenced this issue Jun 16, 2022
DaltonModlin added a commit to DaltonModlin/arrow-rs that referenced this issue Jun 16, 2022
- Removed old builder.rs
- Added missing licensing header to builder submodules
- Updated builder submodule imports and exports
- Updated array mod file builder imports and exports
DaltonModlin added a commit to DaltonModlin/arrow-rs that referenced this issue Jun 16, 2022
DaltonModlin added a commit to DaltonModlin/arrow-rs that referenced this issue Jun 16, 2022
- Removed old builder.rs
- Added missing licensing header to builder submodules
- Updated builder submodule imports and exports
- Updated array mod file builder imports and exports
alamb pushed a commit that referenced this issue Jun 17, 2022
* Split up arrow::array::builder module (#1843)

* Split up arrow::array::builder module (#1843)

- Removed old builder.rs
- Added missing licensing header to builder submodules
- Updated builder submodule imports and exports
- Updated array mod file builder imports and exports
@alamb alamb changed the title Split up arrow::array::builder module Split up arrow::array::builder module Jun 23, 2022
@alamb alamb added the arrow Changes to the arrow crate label Jun 23, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this issue Jun 23, 2022
tustvold added a commit that referenced this issue Jun 23, 2022
…1928)

* Fix merge conflicts from (#1879)

* Split out of decimal_builder (#1843)

* Fix RAT

* Format

* Restore (#1842)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted
Projects
None yet
2 participants