Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ArrayData::validate_dictionary_offset to ArrayData::validate_values #1812

Closed
tustvold opened this issue Jun 7, 2022 · 1 comment · Fixed by #1889
Closed

Rename ArrayData::validate_dictionary_offset to ArrayData::validate_values #1812

tustvold opened this issue Jun 7, 2022 · 1 comment · Fixed by #1889
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted

Comments

@tustvold
Copy link
Contributor

tustvold commented Jun 7, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

ArrayData::validate_dictionary_offset no longer just validates dictionary offsets and instead verifies array offsets, decimal precision, etc..

Describe the solution you'd like

I would like to propose renaming ArrayData::validate_dictionary_offset to ArrayData::validate_values. Potentially first deprecating the old method.

Describe alternatives you've considered

We could not do this.

Additional context
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Jun 7, 2022
@viirya
Copy link
Member

viirya commented Jun 7, 2022

+1 for this.

@frolovdev frolovdev mentioned this issue Jun 16, 2022
Merged
@alamb alamb changed the title Rename ArrayData::validate_dictionary_offset Rename ArrayData::validate_dictionary_offset to ArrayData::validate_values Jun 23, 2022
@alamb alamb added the arrow Changes to the arrow crate label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename ArrayData::validate_dict_offsets to ArrayData::validate_values frolovdev/arrow-rs
3 participants
@viirya @alamb @tustvold