Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parquet Snappy Codec overwrites Existing Data in Decompression Buffer #1806

Closed
tustvold opened this issue Jun 7, 2022 · 0 comments · Fixed by #1807
Closed

Parquet Snappy Codec overwrites Existing Data in Decompression Buffer #1806

tustvold opened this issue Jun 7, 2022 · 0 comments · Fixed by #1807
Labels
bug parquet Changes to the parquet crate

Comments

@tustvold
Copy link
Contributor

tustvold commented Jun 7, 2022

Describe the bug

Calling SnappyCodec::decompress with a non-empty output_buf will trample any data that already exists in the buffer.

To Reproduce

Calling SnappyCodec::decompress with a non-empty output_buf will trample any data that already exists in the buffer.

Expected behavior

It should append to the end of the passed Vec
@tustvold tustvold added the bug label Jun 7, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this issue Jun 7, 2022
@tustvold
Don't trample existing data on snappy decompress (apache#1806)
61542f0
@tustvold tustvold mentioned this issue Jun 7, 2022
Merged
@alamb alamb changed the title Parquet SnappyCodec Tramples Existing Data in Decompressed Buffer Parquet Snappy Codec Tramples Existing Data in Decompressed Buffer Jun 7, 2022
tustvold added a commit that referenced this issue Jun 8, 2022
@tustvold
Don't overwrite existing data on snappy decompress (#1806) (#1807)
1d31d30 
* Don't trample existing data on snappy decompress (#1806)

* Review feedback
@alamb alamb changed the title Parquet Snappy Codec Tramples Existing Data in Decompressed Buffer Parquet Snappy Codec overwrites Existing Data in Decompression Buffer Jun 9, 2022
@alamb alamb added the parquet Changes to the parquet crate label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't overwrite existing data on snappy decompress (#1806) tustvold/arrow-rs
2 participants
@alamb @tustvold