Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPC writer should write validity buffer for UnionArray in V4 IPC message #1793

Closed
viirya opened this issue Jun 5, 2022 · 0 comments · Fixed by #1794
Closed

IPC writer should write validity buffer for UnionArray in V4 IPC message #1793

viirya opened this issue Jun 5, 2022 · 0 comments · Fixed by #1794
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Jun 5, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

In V4, only null types have no validity bitmap. So in V4 message, IPC writer should still write validity buffer for UnionArray for compatibility.

C++ IPC writer:
https://github.com/apache/arrow/blob/c715bebbd89089f385c9996560866da23ea1ddda/cpp/src/arrow/ipc/writer.cc#L158-L168

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Jun 5, 2022
@alamb alamb changed the title IPC writer should write validity buffer for UnionArray in V4 IPC message IPC writer should write validity buffer for UnionArray in V4 IPC message Jun 9, 2022
@alamb alamb added the arrow Changes to the arrow crate label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants