Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema comparison for non_canonical_map when running flight test #1730

Closed
viirya opened this issue May 23, 2022 · 0 comments · Fixed by #1731
Closed

Fix schema comparison for non_canonical_map when running flight test #1730

viirya opened this issue May 23, 2022 · 0 comments · Fixed by #1731
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented May 23, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Part of #1404. When I re-verify fixed integration tests. Just found I miss the case with --run-flight, when running non_canonical_map integration test, the fetched schema from flight is with canonical map field name:

  left: `Schema { fields: [Field { name: "map_other_names", data_type: Map(Field { name: "some_entries", data_type: Struct([Field { name: "some_key", data_type: U
tf8, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: None }, Field { name: "some_value", data_type: Int32, nullable: true, dict_id: 0, dict_is_orde
red: false, metadata: None }]), nullable: false, dict_id: 0, dict_is_ordered: false, metadata: None }, false), nullable: true, dict_id: 0, dict_is_ordered: false,
 metadata: None }], metadata: {} }`,
 right: `Schema { fields: [Field { name: "map_other_names", data_type: Map(Field { name: "entries", data_type: Struct([Field { name: "key", data_type: Utf8, nulla
ble: false, dict_id: 0, dict_is_ordered: false, metadata: None }, Field { name: "value", data_type: Int32, nullable: true, dict_id: 0, dict_is_ordered: false, met
adata: None }]), nullable: false, dict_id: 0, dict_is_ordered: false, metadata: None }, false), nullable: true, dict_id: 0, dict_is_ordered: false, metadata: None

So the C++ flight server changes uploaded non canonical map type to canonical one.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label May 23, 2022
@alamb alamb added the arrow Changes to the arrow crate label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants