Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flight_client_scenarios integration test should receive schema from flight data #1669

Closed
viirya opened this issue May 7, 2022 · 0 comments · Fixed by #1670
Closed

flight_client_scenarios integration test should receive schema from flight data #1669

viirya opened this issue May 7, 2022 · 0 comments · Fixed by #1670
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented May 7, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Part of #1404. This is for generate_nested_dictionary_case, C++ producing, Rust consuming case.

Currently we take the schema of uploaded data as expected schema, using it when reading dictionary and record batches. But it causes some errors when integrating with C++ producing cases. After uploading data, the received schema from flight data could be different in dictionary ids. So it looks like C++ assigns different dictionary ids, although the actual dictionary encoded batches are the same.

Because we use dictionary ids to find correspond dictionary encoded data, incorrect dictionary ids cause unexpected error. As the scenarios is to test flight client, we should use the schema received from flight data too.

After #1635 and #1646, this is the last piece for fully enabling generate_nested_dictionary_case in archery --debug integration --run-flight --with-cpp=true --with-rust=true.

Describe the solution you'd like
generate_nested_dictionary_case should be passed.

Describe alternatives you've considered

Additional context
#1404

@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label May 7, 2022
@alamb alamb added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate and removed arrow-flight Changes to the arrow-flight crate labels May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants