Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Unit Test Coverage of MapArrayReader #1561

Closed
tustvold opened this issue Apr 13, 2022 · 2 comments · Fixed by #2500
Closed

Improve Unit Test Coverage of MapArrayReader #1561

tustvold opened this issue Apr 13, 2022 · 2 comments · Fixed by #2500
Assignees
@frolovdev
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

There is no unit test coverage of MapArrayReader that I can find

Describe the solution you'd like

We should have some unit tests
@tustvold tustvold added good first issue Good for newcomers enhancement Any new improvement worthy of a entry in the changelog labels Apr 13, 2022
@frolovdev
Copy link
Contributor

frolovdev commented Jun 17, 2022 •
edited

@tustvold, hi there, I guess I can help, could you assign it to me?

@tustvold
Copy link
Contributor Author

Thank you, FWIW I think MapArrayReader may currently be incorrect, see #1699, but up to you if you want to tackle that - Dremel encoding is very head hurty

tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 18, 2022
@tustvold
Fix MapArrayReader (apache#2484) (apache#1699) (apache#1561)
4b8a376
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 18, 2022
@tustvold
Fix MapArrayReader (apache#2484) (apache#1699) (apache#1561)
9768bd9
@tustvold tustvold mentioned this issue Aug 18, 2022
Merged
tustvold added a commit that referenced this issue Aug 18, 2022
@tustvold
Fix MapArrayReader (#2484) (#1699) (#1561) (#2500)
c34f07f 
* Fix MapArrayReader (#2484) (#1699) (#1561)

* Fix comments

* Review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frolovdev frolovdev

Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix MapArrayReader (#2484) (#1699) (#1561) tustvold/arrow-rs
2 participants
@tustvold @frolovdev