Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native comparison kernel support for FixedSizeBinaryArray #1109

Closed
tustvold opened this issue Dec 29, 2021 · 5 comments
Closed

Add native comparison kernel support for FixedSizeBinaryArray #1109

tustvold opened this issue Dec 29, 2021 · 5 comments
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers

Comments

@tustvold
Copy link
Contributor

tustvold commented Dec 29, 2021

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently there is no support for comparing FixedSizeBinaryArray

Describe the solution you'd like

It should be possible to call arrow::compute::eq_dyn, and friends with FixedSizeBinaryArray as arguments and have them not return an error. It may be possible to share code with the existing utf8 implementation.

Additional context

Encountered whilst implementing #1053

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Dec 29, 2021
@alamb
Copy link
Contributor

alamb commented Jan 13, 2022

This is a pretty good ticket for anyone who wants to mess with the compute kernels -- basically it should be add a small amount of code and a a test

@alamb alamb added the good first issue Good for newcomers label Jan 13, 2022
@jackwener
Copy link
Member

It's a nice job! I'm interested in this, I can take it up.

@xudong963
Copy link
Member

It's a nice job! I'm interested in this, I can take it up.

I noticed you are also interested in some other issues, I think if the issue is not explicitly assigned or someone explicitly says they are doing it, you can code after indicating you are going to start doing it, look forward to your PRs, thanks

@jackwener
Copy link
Member

It's a nice job! I'm interested in this, I can take it up.

I noticed you are also interested in some other issues, I think if the issue is not explicitly assigned or someone explicitly says they are doing it, you can code after indicating you are going to start doing it, look forward to your PRs, thanks

Thanks for you remind and help😀

@viirya
Copy link
Member

viirya commented Jan 2, 2023

This can be closed as the comparison between FixedSizeBinaryArray is added by #3054.

@viirya viirya closed this as completed Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants