From 0d0c02e71e62f79c0c4012451247849b631d15a4 Mon Sep 17 00:00:00 2001 From: Yichi Zhang <109252977+YichiZhang0613@users.noreply.github.com> Date: Sun, 5 May 2024 03:54:28 +0800 Subject: [PATCH] Tweak Private Sbbf::new_with_ndv_fpp Documentation (#5718) * Solve Inconsistency * Solve inconsistency * Solve inconsistency --- parquet/src/bloom_filter/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parquet/src/bloom_filter/mod.rs b/parquet/src/bloom_filter/mod.rs index ebdb3999424..f746d8b9a8d 100644 --- a/parquet/src/bloom_filter/mod.rs +++ b/parquet/src/bloom_filter/mod.rs @@ -233,7 +233,7 @@ fn num_of_bits_from_ndv_fpp(ndv: u64, fpp: f64) -> usize { impl Sbbf { /// Create a new [Sbbf] with given number of distinct values and false positive probability. - /// Will panic if `fpp` is greater than 1.0 or less than 0.0. + /// Will return an error if `fpp` is greater than or equal to 1.0 or less than 0.0. pub(crate) fn new_with_ndv_fpp(ndv: u64, fpp: f64) -> Result { if !(0.0..1.0).contains(&fpp) { return Err(ParquetError::General(format!(