Update to arrow 19.0.0
#2955
Update to arrow 19.0.0
#2955
Conversation
github-actions
bot
added
core
alamb
force-pushed
the
alamb/update_arrow_19.0.0
branch
from
dde2b4f
to
dd1684c
Compare
| @@ -527,15 +527,15 @@ macro_rules! build_values_list { | |||
| for scalar_value in $VALUES { | |||
| match scalar_value { | |||
| ScalarValue::$SCALAR_TY(Some(v)) => { | |||
| builder.values().append_value(v.clone()).unwrap() | |||
| builder.values().append_value(v.clone()); | |||
There was a problem hiding this comment.
Many of the changes in this PR are driven by apache/arrow-rs#2103 (that made the builders to infallible)
| @@ -917,6 +917,11 @@ impl ScalarValue { | |||
| ScalarValue::iter_to_decimal_array(scalars, precision, scale)?; | |||
| Arc::new(decimal_array) | |||
| } | |||
| DataType::Decimal256(_, _) => { | |||
There was a problem hiding this comment.
| @@ -1112,14 +1117,14 @@ impl ScalarValue { | |||
| scalars: impl IntoIterator<Item = ScalarValue>, | |||
| precision: &usize, | |||
| scale: &usize, | |||
| ) -> Result<DecimalArray> { | |||
| ) -> Result<Decimal128Array> { | |||
There was a problem hiding this comment.
DecimalArray now is DecimalArray128 to add support of DecimalArray256 -- in apache/arrow-rs#2101
| rows: RecordSlice, | ||
| col_name: &str, | ||
| ) -> ArrowResult<ArrayRef> { | ||
| fn build_boolean_array(&self, rows: RecordSlice, col_name: &str) -> ArrayRef { |
There was a problem hiding this comment.
This is another example showing the builders have become infallable
| @@ -271,12 +271,18 @@ mod tests { | |||
|
|
|||
| #[test] | |||
| fn test_cast_decimal_to_decimal() -> Result<()> { | |||
| let array = vec![1234, 2222, 3, 4000, 5000]; | |||
| let array = vec
|
Benchmark runs are scheduled for baseline = c345f6d and contender = cd31649. cd31649 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Draft until arrow 19.0.0 is released, see apache/arrow-rs#2051 for detailsCloses #2973
Closes #2974
Closes #2975