Fix ScalarValue::isNull calculation
#2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
ScalarValue::isNull calculation
alamb
commented
Jun 29, 2022
| @@ -625,32 +625,36 @@ impl ScalarValue { | |||
|
|
|||
| /// whether this value is null or not. | |||
| pub fn is_null(&self) -> bool { | |||
| matches!( | |||
| *self, | |||
| ScalarValue::Null | |||
There was a problem hiding this comment.
You can see there are several types that are not covered (ScalarValue::Binary was what triggered the specific error I investiated). However, there was similar issues for other variants such as Interval, etc
I have changed the code to use a match so if new variants of ScalarValue are added, this list will also need to be updated.
Dandandan
approved these changes
Jun 30, 2022
viirya
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #2778
Rationale for this change
apache/arrow-rs#1888 (added in
arrow 17.0.0) added validation toRecordBatchif the schema's declared nullability is different than its actual nullability it throws a runtime error.What changes are included in this PR?
Correct
ScalarValue::isNullThere are no additional tests in this PR -- they are covered in #2778
Are there any user-facing changes?
More accurate schema calculations