Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix schema nullability for information_schema schema #2804

Merged
merged 1 commit into from Jun 28, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 28, 2022

Which issue does this PR close?

Part of #2778

Rationale for this change

apache/arrow-rs#1888 (added in arrow 17.0.0) added validation to RecordBatch if the schema's declared nullability is different than its actual nullability it throws a runtime error.

What changes are included in this PR?

Correct declared schema nullability in information_schema calculations

There are no tests in this PR -- they are covered in #2778

Are there any user-facing changes?

kind of -- the schema of information_schema is slightly different (some columns are now marked as nullable)

@github-actions github-actions bot added the core Core datafusion crate label Jun 28, 2022
@alamb alamb mentioned this pull request Jun 28, 2022
6 tasks
@andygrove andygrove merged commit ca23fb4 into apache:master Jun 28, 2022
@alamb alamb deleted the alamb/fix_inforation_schema branch August 8, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants