Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Bloom Filter in parquet reader #4512

Closed
5 tasks
alamb opened this issue Dec 5, 2022 · 17 comments
Closed
5 tasks

Support Bloom Filter in parquet reader #4512

alamb opened this issue Dec 5, 2022 · 17 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@alamb
Copy link
Contributor

alamb commented Dec 5, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Bloom filter support was added to arrow-rs in 28.0.0 (as part of apache/arrow-rs#3023). Here is some of that background copy/pasted:

There are usecases where one wants to search a large amount of parquet data for a relatively small number of rows. For example, if you have distributed tracing data stored as parquet files and want to find the data for a particular trace.

In general, the pattern is "needle in a haystack type query" -- specifically a very selective predicate (passes on only a few rows) on high cardinality (many distinct values) columns.

Datafusion has fairly advanced support for

  • row_group pruning
  • page index pruning
  • filter pushdown / late materialization

These techniques are quite effective when data is sorted and large contiguous ranges of rows can be skipped. However, doing needle in the haystack queries still often requires substantial amounts of CPU and IO

One challenge is that for typical high cardinality columns such as ids, they often (by design) span the entire range of values of the data type

For example, given the best case when the data is "optimally sorted" by id within a row group, min/max statistics can not help skip row groups or pages. Instead the entire column must be decoded to search for a particular value

┌──────────────────────────┐                WHERE                 
│            id            │       ┌─────── id = 54322342343      
├──────────────────────────┤       │                              
│       00000000000        │       │                              
├──────────────────────────┤       │    Selective predicate on a  
│       00054542543        │       │    high cardinality column   
├──────────────────────────┤       │                              
│           ...            │       │                              
├──────────────────────────┤       │                              
│        ??????????        │◀──────┘                              
├──────────────────────────┤          Can not rule out ranges     
│           ...            │            using min/max values      
├──────────────────────────┤                                      
│       99545435432        │                                      
├──────────────────────────┤                                      
│       99999999999        │                                      
└──────────────────────────┘                                      
                                                                  
  High cardinality column:                                        
    many distinct values                                          
          (sorted)                                                
                                                                  
┌ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ┐                                           
   min: 00000000000                                               
│  max: 99999999999   │                                           
                                                                  
│       Metadata      │                                           
 ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─                                                                                     

The parquet file format has support for bloom filters: https://github.com/apache/parquet-format/blob/master/BloomFilter.md

A bloom filter is a space efficient structure that allows determining if a value is not in a set quickly. So for a parquet file with bloom filters for id in the metadata, the entire row group can be skipped if the id is not present:

┌──────────────────────────┐                WHERE                
│            id            │      ─ ─ ─ ─ ─ id = 54322342343     
├──────────────────────────┤     │                               
│       00000000000        │           Can quickly check if      
├──────────────────────────┤     │    the value  54322342343     
│       00054542543        │             is not present by       
├──────────────────────────┤     │     consulting the Bloom      
│           ...            │                  Filter             
├──────────────────────────┤     │                               
│        ??????????        │                                     
├──────────────────────────┤     │                               
│           ...            │                                     
├──────────────────────────┤     │                               
│       99545435432        │                                     
├──────────────────────────┤     │                               
│       99999999999        │                                     
└──────────────────────────┘     │                               
  High cardinality column:                                       
    many distinct values         │                               
          (sorted)                                               
                                 │                               
                                                                 
┌ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─      │                               
                           │                                     
│    bloom_filter: ....  ◀ ─ ─ ─ ┘                               
                           │                                     
│  min: 00000000000                                              
   max: 99999999999        │                                     
│                                                                
        Metadata           │                                     
└ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─                                      

Describe the solution you'd like
I would like the ParquetReader in DataFusion to take advantage of Bloom filters when they are present.

This would be in addition to page_filter and row_filter

Some high level steps are probably:

Describe alternatives you've considered
Don't add support ?

Additional context

Some additional support to properly write bloom filters: apache/arrow-rs#3275

@alamb alamb added the enhancement New feature or request label Dec 5, 2022
@alamb alamb changed the title Add Bloom Filter support to parquet reader Support Bloom Filter in parquet reader Dec 5, 2022
@alamb alamb added the help wanted Extra attention is needed label Dec 5, 2022
@ajayaa
Copy link
Contributor

ajayaa commented Dec 11, 2022

@alamb - Interested in picking this up unless you or someone else is working on this that I know of

@alamb
Copy link
Contributor Author

alamb commented Dec 12, 2022

Thanks @ajayaa -- that is great news. No one is actively working on this, though I have time set aside to help with implementation

People who might be interested and were involved with other parts of the implementation might be @tustvold @Jimexist @thinkharderdev and @Ted-Jiang

@ajayaa
Copy link
Contributor

ajayaa commented Dec 12, 2022

Thanks @alamb . Pretty new to rust-lang - please bear with me. I should have something in the next 4-5 days.

@ajayaa
Copy link
Contributor

ajayaa commented Dec 12, 2022

BTW - I started with this small PR - #4583. Would appreciate if could take a look @alamb. I haven't ported all the tests. Just wanted to make I am on the right track before porting over everything.

@Ted-Jiang
Copy link
Member

If no one has started yet , i will start this one 😄

@alamb
Copy link
Contributor Author

alamb commented Jan 17, 2023

Awesome -- thanks @Ted-Jiang . Another interesting project might be #4085 ;)

@ozgrakkurt
Copy link
Contributor

Hey @alamb! it seems like this was postponed? Can I take this if @Ted-Jiang isn't working on it anymore?

@alamb
Copy link
Contributor Author

alamb commented Aug 5, 2023

Hi @ozgrakkurt -- it is fine with me ! I don't know of anyone else working on this at this time. Maybe @tustvold knows more but I suspect the community would be very appreciative of contributions in this area.

@ozgrakkurt
Copy link
Contributor

Hi @ozgrakkurt -- it is fine with me ! I don't know of anyone else working on this at this time. Maybe @tustvold knows more but I suspect the community would be very appreciative of contributions in this area.

Thanks! for now I changed to external indexing implementation in my project but will try to do this when I get free time

@hengfeiyang
Copy link
Contributor

@Ted-Jiang Are you still working on it?

@hengfeiyang
Copy link
Contributor

@ozgrakkurt Do you have time to do this? this is an awesome feature

@Ted-Jiang
Copy link
Member

@ozgrakkurt Sure plz go ahead ! I will be glad if this feature is supported 👍

@Ted-Jiang
Copy link
Member

Maybe you should start with the arrow-rs

@hengfeiyang
Copy link
Contributor

@Ted-Jiang I am looking into this issue. i looked at your draft PR and the latest code of datafusion, we can create a method in datafusion/core/src/datasource/physical_plan/parquet/row_groups.rs, but we need a reader to read the bloom filter data, the reader created at here https://github.com/apache/arrow-datafusion/blob/31.0.0/datafusion/core/src/datasource/physical_plan/parquet.rs#L427 can't use to load data, Any suggestion for implement this? Thanks.

@Ted-Jiang
Copy link
Member

@hengfeiyang have you seen this issue apache/arrow-rs#3851 , I used to decide going this way but something in my company stop me move on..

@hengfeiyang
Copy link
Contributor

@Ted-Jiang Thanks, let me check.

@alamb
Copy link
Contributor Author

alamb commented Nov 6, 2023

Completed by #7821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants