Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace &Option<T> with Option<&T> #4446

Merged
merged 4 commits into from Dec 1, 2022
Merged

Replace &Option<T> with Option<&T> #4446

merged 4 commits into from Dec 1, 2022

Conversation

askoa
Copy link
Contributor

@askoa askoa commented Nov 30, 2022

Which issue does this PR close?

Part of #4424

Changed some occurrences of &Option<T> with Option<&T>

Are there any user-facing changes?

There might be user facing changes as public functions are modified. Would leave it up to reviewers to add api-change tag.

@github-actions github-actions bot added core Core datafusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Physical Expressions sql labels Nov 30, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @askoa

@askoa
Copy link
Contributor Author

askoa commented Nov 30, 2022

The build failure seems unrelated to this PR.

@alamb
Copy link
Contributor

alamb commented Dec 1, 2022

The CI check has been fixed in #4450

This PR looks like it has some conflicts with master that now need to be fixed, so the next run should pass.

Thanks again @askoa

@alamb alamb merged commit bde3c91 into apache:master Dec 1, 2022
@alamb
Copy link
Contributor

alamb commented Dec 1, 2022

Thanks @askoa

@ursabot
Copy link

ursabot commented Dec 1, 2022

Benchmark runs are scheduled for baseline = 38e9f30 and contender = bde3c91. bde3c91 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core datafusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Physical Expressions sql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants