Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip filter push down on semi/anti joins #3723

Merged

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Oct 5, 2022

Which issue does this PR close?

Closes #2888 and #3416

Rationale for this change

We should not fail a rule because a feature has not yet been implemented

What changes are included in this PR?

Do not attempt to push down filters for semi/anti joins, because that is not implemented yet.

Are there any user-facing changes?

@github-actions github-actions bot added the optimizer Optimizer rules label Oct 5, 2022
@andygrove andygrove marked this pull request as ready for review October 5, 2022 14:30
@andygrove
Copy link
Member Author

Thanks for the review @Dandandan

@andygrove andygrove merged commit 965133c into apache:master Oct 5, 2022
@andygrove andygrove deleted the filter-push-down-ignore-anti-semi branch October 5, 2022 15:47
@ursabot
Copy link

ursabot commented Oct 5, 2022

Benchmark runs are scheduled for baseline = beeb631 and contender = 965133c. 965133c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filter_push_down panics on semi/anti join with join filters
3 participants