Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise Unsupported SQL type for Time(WithTimeZone) and Time(Tz) #3718

Merged
merged 2 commits into from Oct 5, 2022

Conversation

waitingkuo
Copy link
Contributor

Which issue does this PR close?

Closes #3715

Rationale for this change

What changes are included in this PR?

time with time zone and timetz now raise error

DataFusion CLI v12.0.0
❯ SELECT 0::TIME WITH TIME ZONE;
NotImplemented("Unsupported SQL type Time(WithTimeZone)")
❯ SELECT 0::TIMETZ;
NotImplemented("Unsupported SQL type Time(Tz)")

Are there any user-facing changes?

@waitingkuo
Copy link
Contributor Author

@alamb @xudong963

@waitingkuo waitingkuo changed the title Raise Unsupported SQL type for Time(WithTimeZone) and Time(Tz)` Raise Unsupported SQL type for Time(WithTimeZone) and Time(Tz) Oct 4, 2022
@github-actions github-actions bot added core Core datafusion crate sql labels Oct 4, 2022
Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @waitingkuo

@xudong963 xudong963 merged commit beeb631 into apache:master Oct 5, 2022
@ursabot
Copy link

ursabot commented Oct 5, 2022

Benchmark runs are scheduled for baseline = 27f3e90 and contender = beeb631. beeb631 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
Copy link
Contributor

alamb commented Oct 6, 2022

Thanks @waitingkuo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core datafusion crate sql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time With Time Zone should raise error until DataType::Time64 support tz
5 participants