Support column aliases specified by WITH statements
#3717
Conversation
datafusion/sql/src/planner.rs
Outdated
| ) \ | ||
| SELECT * FROM numbers;"; | ||
|
|
||
| let expected = "Projection: #numbers.a, #numbers.b, #numbers.c\ |
There was a problem hiding this comment.
Could you merge lastest from master - we no longer prefix column names with #
There was a problem hiding this comment.
Should be done now, thanks for reminding!
| } else { | ||
| Ok(plan) | ||
| } | ||
| } | ||
|
|
||
| /// Apply the given TableAlias to the top-level projection. | ||
| fn apply_table_alias( |
| ) \ | ||
| SELECT * FROM numbers;"; | ||
|
|
||
| let expected = "Projection: numbers.a, numbers.b, numbers.c\ |
alamb
changed the title
WITH statementsWITH statements
|
Benchmark runs are scheduled for baseline = 64669e9 and contender = 23682f6. 23682f6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3716.
Rationale for this change
Adds support for processing the column aliases already parsed by sqlparser-rs during SQL planning stage.
What changes are included in this PR?
Normally we already had some relevant logic processing these entries for relations, now it is in a separate function where both the CTE planner and the relation planner can use.
Are there any user-facing changes?
This is a fix/feture.