Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename do_data_time_math() to do_date_time_math() #3173

Merged

Conversation

JasonLi-cn
Copy link
Contributor

Which issue does this PR close?

Closes #3172 (comment)

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Physical Expressions label Aug 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3173 (ead870a) into master (89bcfc4) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #3173      +/-   ##
==========================================
- Coverage   85.85%   85.85%   -0.01%     
==========================================
  Files         291      291              
  Lines       52786    52786              
==========================================
- Hits        45320    45317       -3     
- Misses       7466     7469       +3     
Impacted Files Coverage Δ
...tafusion/physical-expr/src/expressions/datetime.rs 84.22% <80.00%> (ø)
datafusion/expr/src/window_frame.rs 92.43% <0.00%> (-0.85%) ⬇️
datafusion/core/src/physical_plan/metrics/value.rs 86.93% <0.00%> (-0.51%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 77.43% <0.00%> (-0.18%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alamb alamb merged commit 85f7fc9 into apache:master Aug 16, 2022
@alamb
Copy link
Contributor

alamb commented Aug 16, 2022

Thanks @JasonLi-cn

@ursabot
Copy link

ursabot commented Aug 16, 2022

Benchmark runs are scheduled for baseline = f677e50 and contender = 85f7fc9. 85f7fc9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename do_data_time_math() to do_date_time_math()
5 participants