Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Remove some redundant code #3169

Merged
merged 1 commit into from Aug 16, 2022
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Aug 15, 2022

Which issue does this PR close?

N/A

Rationale for this change

This is a random cleanup I noticed while working on #3122

What changes are included in this PR?

Simplify code

Are there any user-facing changes?

No

@github-actions github-actions bot added the physical-expr Physical Expressions label Aug 15, 2022
@@ -286,19 +286,13 @@ pub fn create_physical_expr(

let list_exprs = list
.iter()
.map(|expr| match expr {
Expr::Literal(ScalarValue::Utf8(None)) => create_physical_expr(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both match arms are the same. It is interesting clippy didn't tell us about that

@codecov-commenter
Copy link

Codecov Report

Merging #3169 (226a91a) into master (e57dead) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 226a91a differs from pull request most recent head 52339ee. Consider uploading reports for the commit 52339ee to get more accurate results

@@           Coverage Diff           @@
##           master    #3169   +/-   ##
=======================================
  Coverage   85.88%   85.89%           
=======================================
  Files         291      291           
  Lines       52770    52766    -4     
=======================================
  Hits        45321    45321           
+ Misses       7449     7445    -4     
Impacted Files Coverage Δ
datafusion/physical-expr/src/planner.rs 95.27% <100.00%> (+2.90%) ⬆️
datafusion/expr/src/logical_plan/plan.rs 77.77% <0.00%> (-0.18%) ⬇️
datafusion/expr/src/window_frame.rs 93.27% <0.00%> (+0.84%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alamb alamb marked this pull request as ready for review August 16, 2022 00:43
@alamb
Copy link
Contributor Author

alamb commented Aug 16, 2022

cc @Ted-Jiang

@alamb alamb merged commit 8e9a8d5 into apache:master Aug 16, 2022
@ursabot
Copy link

ursabot commented Aug 16, 2022

Benchmark runs are scheduled for baseline = ccd9406 and contender = 8e9a8d5. 8e9a8d5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/random_cleanup branch August 8, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants