Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test case for cast_timestamp_before_1970 #3163

Merged
merged 2 commits into from Aug 15, 2022

Conversation

waitingkuo
Copy link
Contributor

Which issue does this PR close?

Closes #3082

Rationale for this change

this is solved while arrow-rs is upgraded to v20. this pr is to add test cases

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the core Core datafusion crate label Aug 15, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @waitingkuo

@codecov-commenter
Copy link

Codecov Report

Merging #3163 (67e8355) into master (15a9a4b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 67e8355 differs from pull request most recent head 98a67c5. Consider uploading reports for the commit 98a67c5 to get more accurate results

@@           Coverage Diff           @@
##           master    #3163   +/-   ##
=======================================
  Coverage   85.87%   85.88%           
=======================================
  Files         291      291           
  Lines       52758    52769   +11     
=======================================
+ Hits        45307    45320   +13     
+ Misses       7451     7449    -2     
Impacted Files Coverage Δ
datafusion/core/src/physical_plan/mod.rs 88.00% <ø> (ø)
datafusion/core/tests/sql/timestamp.rs 99.81% <100.00%> (+<0.01%) ⬆️
datafusion/expr/src/logical_plan/plan.rs 77.60% <0.00%> (+0.17%) ⬆️
datafusion/core/src/physical_plan/metrics/value.rs 87.43% <0.00%> (+0.50%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alamb alamb merged commit e57dead into apache:master Aug 15, 2022
@ursabot
Copy link

ursabot commented Aug 15, 2022

Benchmark runs are scheduled for baseline = 9543d38 and contender = e57dead. e57dead is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cast string to timestamp crash while we input time before 1970 with floating number second
4 participants