Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DateIntervalExpr to DateTimeIntervalExpr #3150

Merged
merged 1 commit into from Aug 15, 2022
Merged

Rename DateIntervalExpr to DateTimeIntervalExpr #3150

merged 1 commit into from Aug 15, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Aug 15, 2022

Draft until #3110 is merged

Which issue does this PR close?

re #3103

Rationale for this change

As suggested on https://github.com/apache/arrow-datafusion/pull/3110/files#r944322483

Since DateIntervalExpr now handles Timestamps in addition to Dates calling it DateTimeIntervalExpr makes sense.

What changes are included in this PR?

Rename DateIntervalExpr to DateTimeIntervalExpr

Are there any user-facing changes?

The struct name is changed

@github-actions github-actions bot added core Core datafusion crate logical-expr Logical plan and expressions physical-expr Physical Expressions labels Aug 15, 2022
@alamb alamb marked this pull request as ready for review August 15, 2022 18:09
@alamb
Copy link
Contributor Author

alamb commented Aug 15, 2022

cc @JasonLi-cn @avantgardnerio

@github-actions github-actions bot removed core Core datafusion crate logical-expr Logical plan and expressions labels Aug 15, 2022
@alamb alamb mentioned this pull request Aug 15, 2022
Merged
avantgardnerio
avantgardnerio approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@avantgardnerio avantgardnerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb alamb merged commit fb70057 into apache:master Aug 15, 2022
@alamb alamb deleted the alamb/rename_datetimeexpr branch August 15, 2022 20:57
@ursabot
Copy link

ursabot commented Aug 15, 2022

Benchmark runs are scheduled for baseline = d9dab92 and contender = fb70057. fb70057 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avantgardnerio avantgardnerio avantgardnerio approved these changes

Assignees
No one assigned
Labels
physical-expr Physical Expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alamb @ursabot @avantgardnerio