From 11f4e5d68d93517d1b00bda4dd52ceee56050d38 Mon Sep 17 00:00:00 2001 From: jorrick Date: Wed, 27 Jul 2022 20:22:16 +0200 Subject: [PATCH 1/2] Remove useless logging line --- airflow/models/dagrun.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/airflow/models/dagrun.py b/airflow/models/dagrun.py index 64c27303a1f6a..992690ab96821 100644 --- a/airflow/models/dagrun.py +++ b/airflow/models/dagrun.py @@ -728,9 +728,12 @@ def _filter_tis_and_exclude_removed(dag: "DAG", tis: List[TI]) -> Iterable[TI]: try: ti.task = dag.get_task(ti.task_id) except TaskNotFound: - self.log.error("Failed to get task for ti %s. Marking it as removed.", ti) - ti.state = State.REMOVED - session.flush() + if ti.state == State.REMOVED: + pass # ti has already been removed, just ignore it + else: + self.log.error("Failed to get task for ti %s. Marking it as removed.", ti) + ti.state = State.REMOVED + session.flush() else: yield ti From 2e1b6e548d65ee13e1d7c272f8513c953aca1bf6 Mon Sep 17 00:00:00 2001 From: Jorrick Sleijster Date: Wed, 27 Jul 2022 21:26:28 +0200 Subject: [PATCH 2/2] IF/Else statement; more implicit, yet explicit enough. Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> --- airflow/models/dagrun.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/airflow/models/dagrun.py b/airflow/models/dagrun.py index 992690ab96821..fde2aa7685ed5 100644 --- a/airflow/models/dagrun.py +++ b/airflow/models/dagrun.py @@ -728,9 +728,7 @@ def _filter_tis_and_exclude_removed(dag: "DAG", tis: List[TI]) -> Iterable[TI]: try: ti.task = dag.get_task(ti.task_id) except TaskNotFound: - if ti.state == State.REMOVED: - pass # ti has already been removed, just ignore it - else: + if ti.state != State.REMOVED: self.log.error("Failed to get task for ti %s. Marking it as removed.", ti) ti.state = State.REMOVED session.flush()