Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encrypt trigger kwargs on first read, if not already encrypted yet #39265

Open
1 of 2 tasks
jedcunningham opened this issue Apr 25, 2024 · 0 comments
Open
1 of 2 tasks

Encrypt trigger kwargs on first read, if not already encrypted yet #39265

jedcunningham opened this issue Apr 25, 2024 · 0 comments
Labels
kind:feature Feature Requests

Comments

@jedcunningham
Copy link
Member

Description

If there are triggers running when an offline migration happens to 2.9.0+, the trigger kwargs aren't encrypted. We've added logic to notice this and return the value before trying to decrypt it in #39246.

However, we deferred the work of doing that encryption when the first read happens. It'd be useful to do that so the existing triggers get encrypted when the triggerer picks them up.

Use case/motivation

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@jedcunningham jedcunningham added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet and removed needs-triage label for new issues that we didn't triage yet labels Apr 25, 2024
@jedcunningham jedcunningham mentioned this issue Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:feature Feature Requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jedcunningham