Fix getting the dag/task ids from base executor #27550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was skipping the 3rd position in the command during validation. This caused the dag_id to be missed and the return from the get_parsing_context() (from airflow/utils/dag_parsing_context.py) had the wrong information. The dag_id contained the task_id and the task_id contained the run_id. Changed starting index when getting the dag and task ids to avoid skipping and added test for base executor.
|
Ah Indeed. That was used in CeleryExecutor. Bummer |
potiuk
approved these changes
Nov 7, 2022
|
Off-by-one :( |
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 9, 2022
(cherry picked from commit f304df7)
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 9, 2022
(cherry picked from commit f304df7)
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was skipping the 3rd position in the command during validation. This caused the dag_id to be missed and the return from the get_parsing_context() (from airflow/utils/dag_parsing_context.py) had the wrong information. The dag_id contained the task_id and the task_id contained the run_id.
Changed starting index when getting the dag and task ids to avoid skipping and added test for base executor.
Issue found when attempting to implement using dag_parsing_context() introduced as part of #25161 to optimize dynamic dag parsing.