Fix sqlalchemy primary key black-out error on DDRQ #27538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Nov 7, 2022
What happened was that the DatasetDagRunQueue(DDRQ) was updated before the change in the consumer dag. During sync to db, the dataset was marked for deletion from the dag causing the primary key in DDRQ to be nullified which threw an error. The solution was to add cascade deletion on DagScheduleDatasetReference relation to DDRQ so that when DagScheduleDatasetReference object is marked for deletion the DDRQ object will also be marked
ephraimbuddy
force-pushed
the
add-cascade-dagscheduleref
branch
from
20730ea
to
76346f8
Compare
ephraimbuddy
added a commit
that referenced
this pull request
Nov 9, 2022
ephraimbuddy
added a commit
that referenced
this pull request
Nov 9, 2022
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened was that the DatasetDagRunQueue(DDRQ) was updated before the change in the consumer dag.
During sync to db, the dataset was marked for deletion from the dag causing the primary key in DDRQ to be nullified which threw an error.
The solution was to add cascade deletion on DagScheduleDatasetReference relation to DDRQ so that when DagScheduleDatasetReference object is marked for deletion the DDRQ object will also be marked
closes: #27509