Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azure, google, authentication library limits to eager upgrade #27535

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Nov 7, 2022

When generating constraints for released providers we hit the same pip resolver backtracking issue - where it took very, very long time to resolve the dependencies for installing released providers on latest airflow from sources.

In #27531 we've added limits to provider.yaml but currently released providers do not have those limits, so until we release them, we should add the limits to "eager upgrade dependencies" in our CI image - to help pip to figure out the right set of dependencies much faster.

Also fixed a problem with extra "." in adal specification (seems it's
been ignored by pip anyway)


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Nov 7, 2022

Constraints are are already manually updated in 1258c93

But this one is to speed up constraint generation for the future builds.

When generating constraints for released providers we hit the same
`pip` resolver backtracking issue - where it took very, very long
time to resolve the dependencies for installing released providers
on latest airflow from sources.

In apache#27531 we've added limits to provider.yaml but currently released
providers do not have those limits, so until we release them, we
should add the limits to "eager upgrade dependencies" in our CI
image - to help `pip` to figure out the right set of dependencies
much faster.

Also fixed a problem with extra "." in adal specification (seems it's
been ignored by `pip` anyway)
@potiuk potiuk force-pushed the speed-up-constraints-generation-for-pypi-packages branch from e2c7e71 to 321408c Compare November 7, 2022 00:13
@potiuk potiuk changed the title Add azure, google, authentication library limits to eaager upgrade Add azure, google, authentication library limits to eager upgrade Nov 7, 2022
@potiuk potiuk merged commit a50195d into apache:main Nov 7, 2022
@potiuk potiuk deleted the speed-up-constraints-generation-for-pypi-packages branch November 7, 2022 01:31
@potiuk potiuk added this to the Airflow 2.4.3 milestone Nov 11, 2022
ephraimbuddy pushed a commit that referenced this pull request Nov 11, 2022
…27535)

When generating constraints for released providers we hit the same
`pip` resolver backtracking issue - where it took very, very long
time to resolve the dependencies for installing released providers
on latest airflow from sources.

In #27531 we've added limits to provider.yaml but currently released
providers do not have those limits, so until we release them, we
should add the limits to "eager upgrade dependencies" in our CI
image - to help `pip` to figure out the right set of dependencies
much faster.

Also fixed a problem with extra "." in adal specification (seems it's
been ignored by `pip` anyway)

(cherry picked from commit a50195d)
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants