Fix mini scheduler expansion of mapped task #27506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
requested review from
uranusjr,
kaxil,
XD-DENG and
ashb
as code owners
ephraimbuddy
commented
Nov 4, 2022
matthewblock
reviewed
Nov 4, 2022
matthewblock
reviewed
Nov 4, 2022
ephraimbuddy
force-pushed
the
fix-mini-scheduler
branch
3 times, most recently
from
fafa450
to
c381035
Compare
uranusjr
reviewed
Nov 9, 2022
ephraimbuddy
force-pushed
the
fix-mini-scheduler
branch
from
c381035
to
84c93c4
Compare
We have a case where the mini scheduler tries to expand a mapped task even when the downstream tasks are not yet done. The mini scheduler extracts a partial subset of a dag and in the process, some upstream tasks are dropped. If the task happens to be a mapped task, the expansion will fail since it needs the upstream output to make the expansion. When the expansion fails, the task is marked as `upstream_failed`. This leads to other downstream tasks being marked as upstream failed. The solution was to ignore this error and not mark the mapped task as upstream_failed when the expansion fails and the dag is a partial subset
ephraimbuddy
force-pushed
the
fix-mini-scheduler
branch
from
84c93c4
to
92b8444
Compare
Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
ephraimbuddy
added a commit
that referenced
this pull request
Nov 9, 2022
We have a case where the mini scheduler tries to expand a mapped task even when the downstream tasks are not yet done. The mini scheduler extracts a partial subset of a dag and in the process, some upstream tasks are dropped. If the task happens to be a mapped task, the expansion will fail since it needs the upstream output to make the expansion. When the expansion fails, the task is marked as `upstream_failed`. This leads to other downstream tasks being marked as upstream failed. The solution was to ignore this error and not mark the mapped task as upstream_failed when the expansion fails and the dag is a partial subset Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com> (cherry picked from commit ed92e5d)
ephraimbuddy
added a commit
that referenced
this pull request
Nov 9, 2022
We have a case where the mini scheduler tries to expand a mapped task even when the downstream tasks are not yet done. The mini scheduler extracts a partial subset of a dag and in the process, some upstream tasks are dropped. If the task happens to be a mapped task, the expansion will fail since it needs the upstream output to make the expansion. When the expansion fails, the task is marked as `upstream_failed`. This leads to other downstream tasks being marked as upstream failed. The solution was to ignore this error and not mark the mapped task as upstream_failed when the expansion fails and the dag is a partial subset Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com> (cherry picked from commit ed92e5d)
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a case where the mini scheduler tries to expand a mapped task even when the downstream tasks are not yet done.
The mini scheduler extracts a partial subset of a dag and in the process, some upstream tasks are dropped.
If the task happens to be a mapped task, the expansion will fail since it needs the upstream output to make the expansion. When the expansion fails, the task is marked as
upstream_failed. This leads to other downstream tasks being marked as upstream failed.The solution was to ignore this error and not mark the mapped task as upstream_failed when the expansion fails and the dag is a partial subset
closes: #27449