Fix caching in CI for pre-commits #27368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
ashb,
mik-laj,
jedcunningham and
kaxil
as code owners
potiuk
force-pushed
the
fix-caching-for-static-checks-in-ci
branch
from
8568f6e
to
2ff835c
Compare
|
This one shaves about 1m from every "build image" step. The images are build in most commits and there is usually "wait for images" step in the "Pull Request" workflow. This might seem small, but in fact it should make most of our workflow complete faster and - most importantly - block other jobs for quite a bit shorter time. |
|
It's about 20-something seconds in fact for build images - but I think it's entirely worth it: Before:
After:
Speeding up static checks is also cool but we will see if it works well only after we merge it. |
|
There are cool follow-ups coming (#27369) so let's merge this one quick :) |
For some time, caching in pre-commits was broken and some of the pre-commit installation was unnecessary. There were few missing or mis-sequenced steps when the CI cache was declered and it made regular PRs us a bit (1-2 minutes) longer time for pre-commit setup than it was needed. In case of image building, there is no need to setup all pre-commits because only one pre-commit is needed (update-generated dependencies) - instead we can simply install rich and yaml locally and run the pre-comit script directly. This PR cleans it up.
potiuk
force-pushed
the
fix-caching-for-static-checks-in-ci
branch
from
2ff835c
to
8574f6f
Compare
eladkal
approved these changes
Oct 30, 2022
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 10, 2022
For some time, caching in pre-commits was broken and some of the pre-commit installation was unnecessary. There were few missing or mis-sequenced steps when the CI cache was declered and it made regular PRs us a bit (1-2 minutes) longer time for pre-commit setup than it was needed. In case of image building, there is no need to setup all pre-commits because only one pre-commit is needed (update-generated dependencies) - instead we can simply install rich and yaml locally and run the pre-comit script directly. This PR cleans it up. (cherry picked from commit 62a870b)
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some time, caching in pre-commits was broken and some of the pre-commit installation was unnecessary. There were few missing or mis-sequenced steps when the CI cache was declered and it made regular PRs us a bit (1-2 minutes) longer time for pre-commit setup than it was needed. In case of image building, there is no need to setup all pre-commits because only one pre-commit is needed (update-generated dependencies) - instead we can simply install rich and yaml locally and run the pre-comit script directly.
This PR cleans it up.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.