Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct timer units to seconds from milliseconds. #27360

Merged
merged 1 commit into from Nov 7, 2022

Conversation

jacobm3
Copy link
Contributor

@jacobm3 jacobm3 commented Oct 29, 2022

dagrun.duration.success.<dag_id>
dagrun.schedule_delay.<dag_id>
dagrun.<dag_id>.first_task_scheduling_delay are reported to statsd in seconds, not milliseconds. Other timers in this list might be suspect, but I haven't checked them yet.

I have a prometheus/grafana test available if anyone would like to use it to confirm the units on these fields. Thanks!


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

``dagrun.duration.success.<dag_id>``
``dagrun.schedule_delay.<dag_id>``
``dagrun.<dag_id>.first_task_scheduling_delay`` are reported to statsd in seconds, not milliseconds. Other timers in this list might be suspect, but I haven't checked them yet.
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 29, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk merged commit 25d7ca9 into apache:main Nov 7, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 7, 2022

Awesome work, congrats on your first merged pull request!

@ephraimbuddy ephraimbuddy added the type:doc-only Changelog: Doc Only label Nov 9, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.4.3 milestone Nov 9, 2022
ephraimbuddy pushed a commit that referenced this pull request Nov 9, 2022
``dagrun.duration.success.<dag_id>``
``dagrun.schedule_delay.<dag_id>``
``dagrun.<dag_id>.first_task_scheduling_delay`` are reported to statsd in seconds, not milliseconds. Other timers in this list might be suspect, but I haven't checked them yet.

(cherry picked from commit 25d7ca9)
ephraimbuddy pushed a commit that referenced this pull request Nov 9, 2022
``dagrun.duration.success.<dag_id>``
``dagrun.schedule_delay.<dag_id>``
``dagrun.<dag_id>.first_task_scheduling_delay`` are reported to statsd in seconds, not milliseconds. Other timers in this list might be suspect, but I haven't checked them yet.

(cherry picked from commit 25d7ca9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants