Add case insensitive constraint to username #27266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
ashb
approved these changes
Oct 25, 2022
jedcunningham
approved these changes
Oct 25, 2022
pierrejeambrun
approved these changes
Oct 25, 2022
ephraimbuddy
force-pushed
the
case-sensitive
branch
from
6cd76b1
to
3e62246
Compare
ephraimbuddy
changed the title
ephraimbuddy
force-pushed
the
case-sensitive
branch
2 times, most recently
from
c2c89fd
to
e837edf
Compare
There was a problem hiding this comment.
I feel like we should add a pre-migration check to look for duplicates before it fails the migration? Like we do for duplicated connection ids?
ephraimbuddy
force-pushed
the
case-sensitive
branch
from
072031e
to
f126955
Compare
ashb
requested changes
Oct 26, 2022
airflow/utils/db.py
Outdated
Comment on lines
956
to
957
| f'Seems you have non unique username in {model.__table__.name} table.\n' # type: ignore | ||
| 'You have to manage those duplicate usernames ' |
There was a problem hiding this comment.
This needs to say something about mixed-case, as otherwise users could be forgiven for thinking that Test and test are different users.
And "manage" isn't clear either -> "delete or rename"
There was a problem hiding this comment.
Addressed. You can take another look. Thanks
ephraimbuddy
force-pushed
the
case-sensitive
branch
from
f126955
to
e636694
Compare
This helps us to recognize usernames properly fixup! Add case insensitive constraint to username check username is unique in check migrations
ephraimbuddy
force-pushed
the
case-sensitive
branch
from
e636694
to
aed1279
Compare
potiuk
reviewed
Oct 27, 2022
| if dups: | ||
| yield ( | ||
| f'Seems you have mixed case usernames in {model.__table__.name} table.\n' # type: ignore | ||
| 'You have to rename or delete those mixed case usernames ' |
There was a problem hiding this comment.
❤️ love the detailed error message
potiuk
approved these changes
Oct 27, 2022
ashb
approved these changes
Oct 31, 2022
ephraimbuddy
added a commit
that referenced
this pull request
Nov 9, 2022
This helps us to recognize usernames properly (cherry picked from commit 1d25105)
ephraimbuddy
added a commit
that referenced
this pull request
Nov 9, 2022
This helps us to recognize usernames properly (cherry picked from commit 1d25105)
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps us to recognize usernames properly