Make RotatingFilehandler used in DagProcessor non-caching #27223
+37
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
uranusjr
reviewed
Oct 24, 2022
potiuk
force-pushed
the
add-non-caching-rotating-handler
branch
3 times, most recently
from
7a2b019 to
8f5a0e0
Compare
The RotatingFileHandler is used when you enable it via `CONFIG_PROCESSOR_MANAGER_LOGGER=True` and it exhibits similar behaviour as the FileHandler had when it comes to caching the file on the Kernel level. While it is harmless (the cache will be freed when needed), it is also misleading for those who are trying to understand memory usage by Airlfow. The fix is to add a custom non-caching RotatingFileHandler similarly as in apache#18054. Note that it will require to manually modify local settings if the settings were created before this change. Fixes: apache#27065
potiuk
force-pushed
the
add-non-caching-rotating-handler
branch
from
8f5a0e0 to
6fecc3a
Compare
uranusjr
approved these changes
Oct 25, 2022
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 9, 2022
The RotatingFileHandler is used when you enable it via `CONFIG_PROCESSOR_MANAGER_LOGGER=True` and it exhibits similar behaviour as the FileHandler had when it comes to caching the file on the Kernel level. While it is harmless (the cache will be freed when needed), it is also misleading for those who are trying to understand memory usage by Airlfow. The fix is to add a custom non-caching RotatingFileHandler similarly as in #18054. Note that it will require to manually modify local settings if the settings were created before this change. Fixes: #27065 (cherry picked from commit 126b7b8)
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 9, 2022
The RotatingFileHandler is used when you enable it via `CONFIG_PROCESSOR_MANAGER_LOGGER=True` and it exhibits similar behaviour as the FileHandler had when it comes to caching the file on the Kernel level. While it is harmless (the cache will be freed when needed), it is also misleading for those who are trying to understand memory usage by Airlfow. The fix is to add a custom non-caching RotatingFileHandler similarly as in #18054. Note that it will require to manually modify local settings if the settings were created before this change. Fixes: #27065 (cherry picked from commit 126b7b8)
2 tasks
18 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RotatingFileHandler is used when you enable it via
CONFIG_PROCESSOR_MANAGER_LOGGER=Trueand it exhibits similar behaviour as the FileHandler had when it comes to caching the file on the Kernel level. While it is harmless (the cache will be freed when needed), it is also misleading for those who are trying to understand memory usage by Airlfow.The fix is to add a custom non-caching RotatingFileHandler similarly as in #18054.
Note that it will require to manually modify local settings if the settings were created before this change.
Fixes: #27065
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.