New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some bug in web ui dags list page (auto-refresh & jump search null state) #27141
Conversation
Signed-off-by: BobDu <i@bobdu.cc>
Signed-off-by: BobDu <i@bobdu.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just left a few minor comments.
Signed-off-by: BobDu <i@bobdu.cc>
Signed-off-by: BobDu <i@bobdu.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
…l state) (#27141) * Fix some bug in web ui dags list page Signed-off-by: BobDu <i@bobdu.cc> * use switch case & fix remove loading dot Signed-off-by: BobDu <i@bobdu.cc> * rename drawDagStats & selectors constants Signed-off-by: BobDu <i@bobdu.cc> * Further clean up of duplicate code Signed-off-by: BobDu <i@bobdu.cc> Signed-off-by: BobDu <i@bobdu.cc> (cherry picked from commit ebd34cb)
…l state) (#27141) * Fix some bug in web ui dags list page Signed-off-by: BobDu <i@bobdu.cc> * use switch case & fix remove loading dot Signed-off-by: BobDu <i@bobdu.cc> * rename drawDagStats & selectors constants Signed-off-by: BobDu <i@bobdu.cc> * Further clean up of duplicate code Signed-off-by: BobDu <i@bobdu.cc> Signed-off-by: BobDu <i@bobdu.cc> (cherry picked from commit ebd34cb)
Hi @BobDu When I'm trying to click on
Traceback-
|
Signed-off-by: BobDu i@bobdu.cc
This is a fix for multiple smiles bug in web ui dags page, but need to modify the same file, so I create a PR.
related: #22900
Before fix,
After fix,
Before fix,
After fix,
related: #26584
Before fix,
http://localhost:8080/taskinstance/list/?_flt_3_dag_id=tutorial&_flt_3_state=null
After fix,
http://localhost:8080/taskinstance/list/?_flt_3_dag_id=tutorial&_flt_8_state=
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.