Remove double collection of dags in airflow dags reserialize
#27030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May reduce the delays seen here |
We explicitly call dagbag.collect_dags after instantiating DagBag in airflow dags reserialize code. The method collect_dags is called on instantiation of the DagBag so calling it again means more processing of the same dags. Here, we use a variable to achieve the same needed effect on reserialization
ephraimbuddy
force-pushed
the
improve-reserialize
branch
from
5edaa68
to
a200d5d
Compare
ashb
reviewed
Oct 13, 2022
Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
ephraimbuddy
changed the title
dagbag.collect_dags in airflow dags reserializeairflow dags reserialize
ephraimbuddy
added a commit
that referenced
this pull request
Oct 18, 2022
We explicitly call dagbag.collect_dags after instantiating DagBag in airflow dags reserialize code. The method collect_dags is called on instantiation of the DagBag so calling it again means more processing of the same dags. Here, we use a variable to achieve the same needed effect on reserialization Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com> (cherry picked from commit 36e2e43)
ephraimbuddy
added a commit
that referenced
this pull request
Oct 18, 2022
We explicitly call dagbag.collect_dags after instantiating DagBag in airflow dags reserialize code. The method collect_dags is called on instantiation of the DagBag so calling it again means more processing of the same dags. Here, we use a variable to achieve the same needed effect on reserialization Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com> (cherry picked from commit 36e2e43)
37 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We explicitly call
dagbag.collect_dagsafter instantiatingDagBagin airflow dags reserialize code.The method
collect_dagsis called on instantiation of the DagBag so calling it again means more processing of the same dags.Here, we use a variable to achieve the same needed effect on reserialization