Reduce log level for k8s TCP_KEEPALIVE etc warnings #26981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
provider:cncf-kubernetes
dstandish
force-pushed
the
reduce-log-level-for-tcp-keepalive
branch
from
1998da7
to
1693c13
Compare
These warnings are emitted when "enable tcp keepalive" is enabled but it's not supported on the machine. Since TCP keepalive enabled is now default for KPO, I don't think it really makes sense to warn just cus the machine doesn't support it. There's nothing you can do about it anyway.
dstandish
force-pushed
the
reduce-log-level-for-tcp-keepalive
branch
from
1693c13
to
8881788
Compare
ephraimbuddy
approved these changes
Oct 12, 2022
ephraimbuddy
added
the
type:misc/internal
|
Since this is changing of log level, I think it should be part of 2.4.2. cc: @jedcunningham |
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 9, 2022
(cherry picked from commit 40d19b9)
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These warnings are emitted when "enable tcp keepalive" is enabled but it's not supported on the machine. Since TCP keepalive enabled is now default for KPO, I don't think it really makes sense to warn just cus the machine doesn't support it. There's nothing you can do about it anyway.