Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed triple quotes in task group example #26829

Merged
merged 1 commit into from Oct 2, 2022
Merged

Conversation

mati-o
Copy link
Contributor

@mati-o mati-o commented Oct 2, 2022

Just noticed that the code sample for task groups wasn't rendered well because the triple quotes did not close properly, so I have added the two missing " chars.

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 2, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@josh-fell josh-fell merged commit 6ddb646 into apache:main Oct 2, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 2, 2022

Awesome work, congrats on your first merged pull request!

@eladkal eladkal added this to the Airflow 2.4.2 milestone Oct 2, 2022
@eladkal eladkal added the type:doc-only Changelog: Doc Only label Oct 2, 2022
@mati-o mati-o deleted the patch-1 branch October 3, 2022 07:30
ephraimbuddy pushed a commit that referenced this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants