Add missing colors to state_color_mapping jinja global #26822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
ryanahamilton,
ashb,
bbovenzi,
kaxil and
potiuk
as code owners
boring-cyborg
bot
added
area:webserver
pierrejeambrun
force-pushed
the
missing-task-state-ui
branch
2 times, most recently
from
692043b
to
62fee69
Compare
pierrejeambrun
force-pushed
the
missing-task-state-ui
branch
from
62fee69
to
19e3661
Compare
uranusjr
approved these changes
Oct 3, 2022
bbovenzi
approved these changes
Oct 3, 2022
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 18, 2022
(cherry picked from commit 9bd3046)
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
state_color_mappingin the jinja global was missing a few task states (removed, restarting, shutdown).All the templates using this global variable were missing these state colors and then considered as 'no status' (white). (Grid, Graph, etc...):
Before
After (cf legends for instance)