Handle mapped tasks in task duration chart #26722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
|
Do you have a before/after screenshot of this? |
|
i will add |
bbovenzi
approved these changes
Sep 27, 2022
Previously mapped tasks each existed as their own independent-but-unlabeled points. Makes sense to aggregate them somehow.
dstandish
force-pushed
the
handle-mapped-tasks-in-task-duration-chart
branch
from
b975273
to
d660752
Compare
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 18, 2022
Previously mapped tasks each existed as their own independent-but-unlabeled points. Makes sense to aggregate them somehow. (cherry picked from commit 8829c07)
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 18, 2022
Previously mapped tasks each existed as their own independent-but-unlabeled points. Makes sense to aggregate them somehow. (cherry picked from commit 8829c07)
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously mapped tasks each existed as their own independent-but-unlabeled points. Makes sense to aggregate them somehow.
Going with sum for now... would avg be better?
Depends on #26717
The before / after images below were achieved by running this a dag with 3 mapped tasks (base task
hello) three times. Each task takes 10 seconds approximately.After - non-cumulative
Before - non-cumulative
After - cumulative
Before - cumululative