Fix task duration cumulative chart #26717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
Previously the chart could go down, which should not happen for a cumulative chart. We fix that here. Also, we add task fail durations to the non-cumulative chart for consistency.
dstandish
force-pushed
the
fix-cumulative-task-duration-chart
branch
from
a343e23
to
0a8a483
Compare
bbovenzi
approved these changes
Sep 27, 2022
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 18, 2022
Previously the chart could go down, which should not happen for a cumulative chart. We fix that here. Also, we add task fail durations to the non-cumulative chart for consistency. (cherry picked from commit afa8e10)
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 18, 2022
Previously the chart could go down, which should not happen for a cumulative chart. We fix that here. Also, we add task fail durations to the non-cumulative chart for consistency. (cherry picked from commit afa8e10)
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the chart could go down, which should not happen for a cumulative chart. We fix that here.
ALSO we add task fail duration to the non-cumulative
Before, it was only added to cumulative.
After fix
Before fix