When rendering template, unmap task in context #26702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
approved these changes
Sep 27, 2022
Currently, when a mapped task is being rendered (and unmapped during the process), the template context continues to reference the mapped task because the context is created before unmapping. This is however not useful, and creates obstacles for use cases needing to reference a task-mapping value (something passed to the expand function). This patch adds logic to replace context["task"] and context["ti"].task in-place when a mapped task is being unmapped, so they always reference an unmapped task during template rendering. This makes writing a Jinja template for a mapped task more consistent to that for a non-mapped one. To accommodate this change in reference, some peripheral code is modified so various task variables point to the right things at the right moment. A few tests are also modified to ensure this in-place replacement is done at the right moment.
|
Something’s wrong with yarnpkg… hopefully temporary? |
uranusjr
force-pushed
the
aip-42-context-task-reference-unmapped
branch
from
225b31b
to
057d66b
Compare
jedcunningham
pushed a commit
that referenced
this pull request
Sep 27, 2022
(cherry picked from commit 5560a46)
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a mapped task is being rendered (and unmapped during the process), the template context continues to reference the mapped task because the context is created before unmapping. This is however not useful, and creates obstacles for use cases needing to reference a task-mapping value (something passed to the expand function).
This patch adds logic to replace
context["task"]andcontext["ti"].taskin-place when a mapped task is being unmapped, so they always reference an unmapped task during template rendering. This makes writing a Jinja template for a mapped task more consistent to that for a non-mapped one.To accommodate this change in reference, some peripheral code is modified so various task variables point to the right things at the right moment. A few tests are also modified to ensure this in-place replacement is done at the right moment.
Fix #24388.