Fix scroll overflow for ConfirmDialog #26681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
boring-cyborg
bot
added
area:UI
pierrejeambrun
force-pushed
the
fix-overflow-for-confirm-dialog
branch
from
02cceb0
to
014a0cd
Compare
bbovenzi
approved these changes
Sep 26, 2022
jedcunningham
approved these changes
Sep 26, 2022
jedcunningham
pushed a commit
that referenced
this pull request
Sep 27, 2022
(cherry picked from commit a836899)
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #26622
When there is a lot of tasks to display in the ConfirmDialog component, content overflows out of the screen. (cf below) and we land directly at the bottom of the scroll without having the disclaimer.
Before:
After
