Simplify RTIF.delete_old_records() #26667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
remove-sqlalchemy-subquery-in-warning
branch
from
bac477d
to
d6f14b6
Compare
A lot of the codes and comments are actually not relevant since we've removed the funky execution_date based filtering in 2.3, and we can simply the implementation quite a bit now.
uranusjr
force-pushed
the
remove-sqlalchemy-subquery-in-warning
branch
from
d6f14b6
to
55619a0
Compare
jedcunningham
approved these changes
Sep 26, 2022
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 18, 2022
A lot of the codes and comments are actually not relevant since we've removed the funky execution_date based filtering in 2.3, and we can simply the implementation quite a bit now. (cherry picked from commit 0e79dd0)
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #26548. I was looking into that warning and realised that the entire MySQL special-case is not relevant anymore and we can simplify this a lot.