Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirements.txt example to "extending docker" #26663

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Sep 25, 2022

When extending the image, there was an example of adding individual packages via PyPI, but not requirements.txt. This PR fixes it.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

When extending the image, there was an example of adding individual
packages via PyPI, but not requirements.txt. This PR fixes it.
@boring-cyborg boring-cyborg bot added area:production-image Production image improvements and fixes kind:documentation labels Sep 25, 2022
@potiuk potiuk added this to the Airflow 2.4.1 milestone Sep 25, 2022
@potiuk
Copy link
Member Author

potiuk commented Sep 25, 2022

Based on discussion with a user (and few other people earlier) https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1664026140619249

@potiuk potiuk merged commit 25fdb2c into apache:main Sep 25, 2022
@potiuk potiuk deleted the add-requirements-txt-docker-extending-example branch September 25, 2022 22:19
@jedcunningham jedcunningham added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Sep 26, 2022
jedcunningham pushed a commit that referenced this pull request Sep 26, 2022
When extending the image, there was an example of adding individual
packages via PyPI, but not requirements.txt. This PR fixes it.

(cherry picked from commit 25fdb2c)
jedcunningham pushed a commit that referenced this pull request Sep 27, 2022
When extending the image, there was an example of adding individual
packages via PyPI, but not requirements.txt. This PR fixes it.

(cherry picked from commit 25fdb2c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:production-image Production image improvements and fixes changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants