Add a note against use of top level code in timetable #26649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
force-pushed
the
doc-improvement
branch
from
77f28d4
to
fc6124f
Compare
potiuk
approved these changes
Sep 25, 2022
uranusjr
reviewed
Sep 26, 2022
Comment on lines
+168
to
+172
| return ( | ||
| f"Timetable class {self.type_string!r} is not registered or " | ||
| "you have a top level database access that disrupted the session. " | ||
| "Please check the airflow best practices documentation." | ||
| ) |
There was a problem hiding this comment.
I sort of feel that mentioning top level database access is a bit too specific. Maybe it’d be better to be slightly more vague here (there’s something wrong with eager variable evaluation in the class) instead. But I’m not strong on this—we can always reword this afterwards.
ephraimbuddy
force-pushed
the
doc-improvement
branch
from
fc6124f
to
6f70a56
Compare
uranusjr
reviewed
Sep 26, 2022
potiuk
approved these changes
Sep 26, 2022
pierrejeambrun
approved these changes
Sep 26, 2022
Accessing Variables, Connections at top level of code is bad practice
ephraimbuddy
force-pushed
the
doc-improvement
branch
from
fc284d7
to
530f076
Compare
ephraimbuddy
added a commit
that referenced
this pull request
Oct 18, 2022
Accessing Variables, Connections at top level of code is bad practice Add a section in best practices ref for timetable (cherry picked from commit 37c0cb6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing Variables, Connections at top level of code is bad practice
closes: #26529