Fix xcom arg.py .zip bug #26636
Merged
Fix xcom arg.py .zip bug #26636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmcginness
force-pushed
the
fix-xcom_arg.py-.zip-bug
branch
2 times, most recently
from
b66c62e
to
ec272af
Compare
rjmcginness
force-pushed
the
fix-xcom_arg.py-.zip-bug
branch
from
ec272af
to
ebff0dd
Compare
uranusjr
approved these changes
Sep 26, 2022
|
Sure. I would be happy to do that. End of the day here and work tomorrow, so it may take a little while. However, I will work on it. |
|
Thanks a lot! Since the apparent issue would be fixed with this PR, the specific root cause can be looked into without breaking things, so there’s no hurry, feel free to do it when you have time. |
|
Sounds good. Glad to help. Airflow is a great project. i’m hoping to learn and do more here. |
👀 |
potiuk
approved these changes
Sep 26, 2022
|
Awesome work, congrats on your first merged pull request! |
jedcunningham
pushed a commit
that referenced
this pull request
Sep 26, 2022
(cherry picked from commit f219bfb)
jedcunningham
pushed a commit
that referenced
this pull request
Sep 27, 2022
(cherry picked from commit f219bfb)
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified xcom_arg.py to test against ArgNotSet type, rather than an instance (NOTSET).
Fixes the filling of the _ZipResult with an erroneous fill value, when zip is called with the
default fillvalue=NOTSET.
closes: #26499
related: #26499