Use COALESCE when ordering runs to handle NULL #26626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data interval columns are NULL for runs created before 2.3, but SQL's NULL-sorting logic would make those old runs always appear first. In a perfect world we'd want to sort by get_run_data_interval(), but that's not efficient, so instead the columns are coalesced into logical date, which is good enough in most cases.
uranusjr
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
ashb
reviewed
Sep 23, 2022
| dag_runs = query.order_by(*ordering, DagRun.id.desc()).limit(num_runs).all() | ||
| dag_runs.reverse() | ||
|
|
||
| dag_runs = wwwutils.sorted_dag_runs(query, ordering=dag.timetable.run_ordering, limit=num_runs) |
There was a problem hiding this comment.
This feels more like it should be a method on DagRun class maybe? (That way this can be used by API or CLI too)
There was a problem hiding this comment.
This function in general includes some UI-specific sorting/slicing logic I don’t feel right making generic. The inner _get_run_ordering_expr probably should, but I’d rather wait until when we actually reuse it somewhere (we don’t right now).
ashb
approved these changes
Sep 26, 2022
2 tasks
jedcunningham
pushed a commit
that referenced
this pull request
Sep 26, 2022
Data interval columns are NULL for runs created before 2.3, but SQL's NULL-sorting logic would make those old runs always appear first. In a perfect world we'd want to sort by get_run_data_interval(), but that's not efficient, so instead the columns are coalesced into logical date, which is good enough in most cases. (cherry picked from commit 22d52c0)
jedcunningham
pushed a commit
that referenced
this pull request
Sep 27, 2022
Data interval columns are NULL for runs created before 2.3, but SQL's NULL-sorting logic would make those old runs always appear first. In a perfect world we'd want to sort by get_run_data_interval(), but that's not efficient, so instead the columns are coalesced into logical date, which is good enough in most cases. (cherry picked from commit 22d52c0)
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data interval columns are NULL for runs created before 2.3, but SQL's NULL-sorting logic would make those old runs always appear first. In a perfect world we'd want to sort by get_run_data_interval(), but that's not efficient, so instead the columns are coalesced into logical date, which is good enough in most cases.
This should #26505, I think. Not sure if the UI side needs some additional work. cc @bbovenzi