Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve warning about DISTINCT ON query on dags view #26608

Merged
merged 1 commit into from Sep 23, 2022
Merged

Resolve warning about DISTINCT ON query on dags view #26608

merged 1 commit into from Sep 23, 2022

Conversation

dstandish
Copy link
Contributor

Previously we'd get this warning:

/Users/dstandish/code/airflow/airflow/www/views.py:710 SADeprecationWarning: DISTINCT ON is currently supported only by the PostgreSQL dialect.  Use of DISTINCT ON for other backends is currently silently ignored, however this usage is deprecated, and will raise CompileError in a future release for all backends that do not support this syntax.

Closes #26607

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Sep 22, 2022
@potiuk potiuk merged commit 55d1146 into apache:main Sep 23, 2022
@ashb ashb deleted the fix-distinct-on-warning branch September 23, 2022 08:53
@jedcunningham jedcunningham added this to the Airflow 2.4.1 milestone Sep 26, 2022
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Sep 26, 2022
jedcunningham pushed a commit that referenced this pull request Sep 26, 2022
@dstandish @jedcunningham
Resolve warning about DISTINCT ON query on dags view (#26608)
e436cb9 
Closes #26607

(cherry picked from commit 55d1146)
jedcunningham pushed a commit that referenced this pull request Sep 27, 2022
@dstandish @jedcunningham
Resolve warning about DISTINCT ON query on dags view (#26608)
ef400fe 
Closes #26607

(cherry picked from commit 55d1146)
@jedcunningham jedcunningham mentioned this pull request Sep 27, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@uranusjr uranusjr uranusjr approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

Assignees
No one assigned
Labels
area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Milestone
Airflow 2.4.1
Development

Successfully merging this pull request may close these issues.

resolve web ui views warning re DISTINCT ON
4 participants
@dstandish @potiuk @uranusjr @jedcunningham