Allow MapXComArg to resolve after serialization #26591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for cases where we want to resolve an XCom without running a worker, e.g. to display the value in UI. Since we don't want to actually call the mapper function in this case (the function is arbitrary code, and not running it is the entire point to serialize operators), "resolving" the XComArg in this case would merely produce some kind of quasi-meaningful string representation, instead of the actual value we'd get in the worker. Also note that this only affects a very small number of cases, since once a worker is run for the task instance, RenderedTaskInstanceFields would store the real resolved value and take over UI representation, avoiding this fake resolving logic to be accessed at all.
ashb
approved these changes
Sep 23, 2022
jedcunningham
approved these changes
Sep 23, 2022
jedcunningham
pushed a commit
that referenced
this pull request
Sep 26, 2022
This is useful for cases where we want to resolve an XCom without running a worker, e.g. to display the value in UI. Since we don't want to actually call the mapper function in this case (the function is arbitrary code, and not running it is the entire point to serialize operators), "resolving" the XComArg in this case would merely produce some kind of quasi-meaningful string representation, instead of the actual value we'd get in the worker. Also note that this only affects a very small number of cases, since once a worker is run for the task instance, RenderedTaskInstanceFields would store the real resolved value and take over UI representation, avoiding this fake resolving logic to be accessed at all. (cherry picked from commit 3e01c0d)
jedcunningham
pushed a commit
that referenced
this pull request
Sep 27, 2022
This is useful for cases where we want to resolve an XCom without running a worker, e.g. to display the value in UI. Since we don't want to actually call the mapper function in this case (the function is arbitrary code, and not running it is the entire point to serialize operators), "resolving" the XComArg in this case would merely produce some kind of quasi-meaningful string representation, instead of the actual value we'd get in the worker. Also note that this only affects a very small number of cases, since once a worker is run for the task instance, RenderedTaskInstanceFields would store the real resolved value and take over UI representation, avoiding this fake resolving logic to be accessed at all. (cherry picked from commit 3e01c0d)
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for cases where we want to resolve an XCom without running a worker, e.g. to display the value in UI, logs, and OpenLineage.
Since we don't want to actually call the mapper function in this case (the function is arbitrary code, and not running it is the entire point to serialize operators), "resolving" the XComArg in this case would merely produce some kind of quasi-meaningful string representation,
instead of the actual value we'd get in the worker.
Also note that this only affects a very small number of cases, since once a worker is run for the task instance, RenderedTaskInstanceFields would store the real resolved value and take over UI representation, avoiding this fake resolving logic to be accessed at all.